Add new matric "spatial distortion index" #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywchan2005
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
github-actions
bot
added
the
documentation
ywchan2005
changed the title
Borda
reviewed
Dec 5, 2023
ywchan2005
changed the title
SkafteNicki
reviewed
Dec 10, 2023
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
…an_lr` as arguments
…ywchan2005/torchmetrics into spatial-distortion-index-metric
SkafteNicki
approved these changes
Dec 20, 2023
justusschock
approved these changes
Dec 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2260 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 296 298 +2
Lines 16709 16854 +145
=======================================
+ Hits 14501 14634 +133
- Misses 2208 2220 +12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new metric 'D_s' (spatial distortion index)
(being part of #799 )
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2260.org.readthedocs.build/en/2260/